Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return user defined type from functionexpression in core, fix handling of XmlEnum in moxy #1923

Merged
merged 7 commits into from
Aug 15, 2023
Merged

return user defined type from functionexpression in core, fix handling of XmlEnum in moxy #1923

merged 7 commits into from
Aug 15, 2023

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Aug 14, 2023 •
edited
Loading

  • fix handling of moxy dynamic classes on JPMS
  • avoid instanceof where possible (in core only)
  • small step towards moxy compatibility with android
  • fix imports in core module
  • Deprecate inefficient Helper.getShortClassName methods and replace their usages

(check this commit by commit, the last one updates imports only)

@lukasj lukasj requested a review from rfelcman August 14, 2023 22:32
@lukasj lukasj changed the title use user defined type from functionexpression in core, fix handling of XmlEnum in moxy return user defined type from functionexpression in core, fix handling of XmlEnum in moxy Aug 14, 2023
rfelcman
rfelcman approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 34042cd into eclipse-ee4j:master Aug 15, 2023
5 checks passed
@lukasj lukasj deleted the fx branch August 15, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasj @rfelcman